-
Notifications
You must be signed in to change notification settings - Fork 16
feat(brigadier): Duplicate literal nodes for each alias with Brigadier #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Brigadier doesn't support aliases, adding the command for each alias inflates the command tree (that's sent to the player) significantly |
|
This is an intentional decision not to create exponentially massive command trees. Brigadier does not have any way to represent aliases and redirects are broken and inconsistent in many ways. If we were to accept something like this it would need to be a per-command-chain option, not entirely sure of the best way to implement that, however. |
@jpenilla What about adding something like |
|
BrigadierSettings is not a per-command-chain configuration. |
Well, either way:
So what's the point of per-command-chain configuration? |
|
Any updates on this? |
|
if the goal is not to make huge command trees then brigadier's |
What's wrong with redirects? If /execute can work surely an alias can? What are the issues currently? |
Fixes #5
As #5 description states, literal node aliases work on command execution, but suggestions don't. As of v2, this is no longer the case (at least on Paper with the modern brig api). Neither suggestions nor running the command work with aliases. So...
🥔