[algorithm] Split algorithm phases in different functions #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thm- completely unnecessary
… proximity back on the from geometry
th-skam
added
pr: enhancement
pr: status to review
…tectionOutput
Ensure they are used across C++ standard evolution
th-skam
force-pushed
the
split-phases
branch
from
cc9945e to
03ab753
Compare
epernod
reviewed
Sep 26, 2025
Contributor
epernod
left a comment
epernod
left a comment
There was a problem hiding this comment.
some conflicts to be solved first
Collaborator
Author
That's done. ready to merge after ci tests |
epernod
approved these changes
Sep 26, 2025
epernod
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow overriding virtual functions in derived classes and enable modifications in external plugins
Dependency
Based #100
Issues
Close #96