improvements in handlers in IdentityComponentsEndpointRouteBuilderExt… #952
+12
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies how client information is handled during login and logout events in the identity endpoints. Instead of passing a complex
ClientIdentificationobject, only the client's IP address is now passed to the handler delegates. The related code for collecting additional client details has been removed, streamlining the logic.Delegate and handler signature changes:
LoginHandlerandLogoutHandlerdelegate signatures to accept only theipAddressstring instead of aClientIdentificationobject. (IdentityComponentsEndpointRouteBuilderExtensions.cs)Simplification of client info usage:
loginHandlerandlogoutHandlerwithinMapAdditionalIdentityEndpointsto pass only the IP address, removing the creation and use of theClientIdentificationobject. (IdentityComponentsEndpointRouteBuilderExtensions.cs) [1] [2] [3] [4] [5]Code cleanup:
ClientIdentificationclass and theGetClientIdentificationmethod, as they are no longer needed. (IdentityComponentsEndpointRouteBuilderExtensions.cs) [1] [2]