Massive type hints improvements + fix tests + update API #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split `Script` class into `Script` and `ManagedScript` to correctly handle environment lifecycles and enforce type safety. - Rename `script` to `load_file` and `code` to `load_code` - Remove `variables` function - Add type overloads for loader functions - Update imports and type aliases BREAKING CHANGE: Renamed `script` and `code` to `load_file` and `load_code`. Removed `variables`.
Rename `module_name` to `module` in `load_file` and `load_code` to allow passing existing module objects. Add overloads to better handle return types based on the provided environment. Update docstrings to fix incorrect parameter references and typos. BREAKING CHANGE: The `module_name` parameter has been renamed to `module`.
also fix a memory leak oops
- Switch build backend to Hatchling with versioningit - Rename package to `vsengine-jet` and update metadata - Add CI workflow for linting and type checking using uv - Update Ruff configuration and enable additional rules - Update README.md with new installation instructions
Refactor the entire test suite to use pytest, removing dependencies on unittest.TestCase. Introduce pytest-asyncio for asynchronous tests and replace the custom wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: More examples