Fix crash when handling offline players and user input #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a critical crash that occurs when trying to view information about an offline player or a player whose session is not properly loaded. It also fixes the root cause of incorrect session creation from user input in forms.
The Problem
The Solution
This PR introduces a multi-level fix:
TagManager.php: A safety check has been added to thedisplay_nametag. It now verifies if the player object is null and falls back to the user's name, preventing any crashes.UserManageForm.php: The user input for the nickname is now sanitized withtrim()to remove any leading or trailing whitespace.SessionManager.php: The session lookup logic has been improved to be case-insensitive. If an exact match for a session is not found, it performs a case-insensitive search before creating a new session.These changes together make the player information forms more robust, prevent crashes, and ensure that the correct user session is always found.