Clarify goal of the spec + trailing commas seperate page #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thank you, I think this is a useful clarification. I personally won't adhere to this specification then since I don't consider it useful for my requirements, but I'm glad there seems to be no room for confusion anymore. |
Alhadis
suggested changes
Aug 25, 2025
Contributor
Alhadis
left a comment
Alhadis
left a comment
There was a problem hiding this comment.
Editorial nits, some of them less important than others.
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Member
Author
|
Thanks @Alhadis for taking the time to make a review. I hope I've addressed your comments and suggestions in a satisfactionary manner. I'll probably merge this soon, but feel free to reply to my comments. Furthermore, there's also the option to discuss and make edits in another PR if pertinent. |
Member
Author
|
I think somehow accepting changes via the GitHub interface (2615c83) is causing the pr-preview to fail 😔, but I'm not too worried... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additions here aim to clarify the goal of the spec:
Provide a definition in accordance with jsonc-parser.
To avoid any ambiguity regarding whether or not a parser needs to implement trailing commas, a separate page is introduced to add more details about them, while keeping the spec short and clear. This should address #5.