Skip to content

code-review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajitatif wants to merge 1 commit into
base: master
Choose a base branch
from
Open

code-review #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 25 additions & 34 deletions workshop-1/jugistanbul-slugifier/src/jug/istanbul/slugifier/Slugifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,48 +6,39 @@

public class Slugifier
{
public static String run ( String text )
private Slugifier() {
}

public static String slugify ( String text ) throws UnsupportedEncodingException
{
if ( text == null || text.length () == 0 )
if ( text == null || text.isEmpty() )
{
return "";
}

String toReturn = "";
try
{
String normalizedText = normalize ( text );
normalizedText = normalizedText.replaceAll ( "[^\\w\\s\\-]", "" );
normalizedText = normalizedText.replaceAll ( " ", "-" );
normalizedText = normalizedText.toLowerCase ();
toReturn = URLEncoder.encode ( normalizedText, "UTF-8" );
}
catch ( UnsupportedEncodingException e )
{
// TODO: Log the exception
e.printStackTrace ();
}

return toReturn;
String normalizedText = normalize ( text )
.replaceAll ( "[^\\w\\s\\-]", "" )
.replaceAll ( " ", "-" )
.toLowerCase ();
return URLEncoder.encode ( normalizedText, "UTF-8" );
}

public static String convertCharactersFromTurkishToEnglish ( String text )
private static String convertCharactersFromTurkishToEnglish ( String text )
{
text = text.replaceAll ( "ü", "u" );
text = text.replaceAll ( "ı", "i" );
text = text.replaceAll ( "ö", "o" );
text = text.replaceAll ( "ü", "u" );
text = text.replaceAll ( "ş", "s" );
text = text.replaceAll ( "ğ", "g" );
text = text.replaceAll ( "ç", "c" );
text = text.replaceAll ( "Ü", "U" );
text = text.replaceAll ( "İ", "I" );
text = text.replaceAll ( "Ö", "O" );
text = text.replaceAll ( "Ü", "U" );
text = text.replaceAll ( "Ş", "S" );
text = text.replaceAll ( "Ğ", "G" );
text = text.replaceAll ( "Ç", "C" );
return text;
return text.replaceAll ( "ü", "u" )
.replaceAll ( "ı", "i" )
.replaceAll ( "ö", "o" )
.replaceAll ( "ü", "u" )
.replaceAll ( "ş", "s" )
.replaceAll ( "ğ", "g" )
.replaceAll ( "ç", "c" )
.replaceAll ( "Ü", "U" )
.replaceAll ( "İ", "I" )
.replaceAll ( "Ö", "O" )
.replaceAll ( "Ü", "U" )
.replaceAll ( "Ş", "S" )
.replaceAll ( "Ğ", "G" )
.replaceAll ( "Ç", "C" );
}

private static String normalize ( String input )
Expand Down