test: fileQueries handling of a 500 Internal Server Error #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkitti
changed the title
mkitti
commented
Jan 6, 2026
| // so we Assert what we WANT (the fix). | ||
| // This test definition asserts the correct behavior. | ||
| // Running it on the buggy branch should FAIL this assertion. | ||
| expect(error?.message).toBe('Server returned 500 Internal Server Error'); |
Contributor
Author
There was a problem hiding this comment.
I think the likely next step here would be to remove or modify this line and keep the next line that checks for the abseence of 'Unexpected token'.
The main point of the test is to make sure that we are not showing JSON parsing errors of other error messages. We may not want to test for a specific error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #283 in part by adding a test for error handling by
fileQueries.js.
When a 500 Internal Server Error was created, we would attempt to parse
the response content as JSON, resulting in another error:
This pull request adds a new test to check for this kind of error message.
The test is expected to fail until #285 is merged.
Assisted by Gemini 3 Pro (Low) via Antigravity.