fix: server response for user context error #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-inherits from PermissionError -created to distinguish this specific configuration error from other PermissionErrors
- not catching PermissionErrors was what was originally causing no JSON response to be returned from the server when setegid, setgroups, or seteuid failed. Even those these specific errors are not caught by the custom error class and handler, I left in the global PermissionError handler to catch other instances where a PermissionError might not be caught in a specific method
- catch PermissionErrors in EffectiveUserContext.__enter__() and raise the new custom error class instead
Member
|
Actually, I wonder if |
Collaborator
Author
I added a check before raising the custom error. If use_access_flags is false, then the PermissionError is raised as-is. |
The error message was replicated in three places. Doing this means we can set it once but still override it if needed.
neomorphic
approved these changes
Jan 6, 2026
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
LGTM! I refactored the error message into the UserContextConfigurationError class so it doesn't need to be written three times.
allison-truhlar
merged commit 2874ca6
into
mkitti-handle-internal-server-errors-file-queries
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup id: 86ae98yg2
This PR adds error handling for user context configuration issues related to access flags and server privileges. It also adds a global error handler for permission errors, to handle any future cases where permission errors are not otherwise caught.
Addresses this comment in PR #283
@krokicki