Avoid undefined behavior on integer overflow #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arithmetic overflow on signed integral types is undefined behavior in C++. In contrast, unsigned types overflow in a well defined manner, modulo MAX(type)+1, which is the right thing when computing differences of timestamps returned by `micros()'. Fixes #3.
|
I strongly second this pull request. As Edgar states, this is undefined behavior otherwise, regardless of whether or not it seems to consistently work. If not fixed it is a definite bug and people shouldn't use your library--but it does look useful so I hope you fix it. Simple fix; simple pull request; I hope you accept it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arithmetic overflow on signed integral types is undefined behavior in
C++. In contrast, unsigned types overflow in a well defined manner,
modulo MAX(type)+1, which is the right thing when computing differences
of timestamps returned by `micros()'.
Fixes #3.