Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/update-stores.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:

- name: Save Store Types JSON Artifact
if: success()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: store-types
path: |
Expand All @@ -117,14 +117,14 @@ jobs:

- name: Save Invalid Store Types JSON Artifact
if: success()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: invalid-repos
path: ./tools/store-type-merge/invalid_repos.json

- name: Save logs directory
if: success()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: logs
path: ./tools/store-type-merge/log
Expand Down
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
# v1.8.2

## Fixes

### CLI

- Silence logging of initial `store-type` fetch
- `store-types`: Update internal definitions to latest from Keyfactor GitHub repos.
- `version` update internal version to `1.8.2`

### Chores

- `docs`: Add `migration` auto docs
- `docs`: Refresh auto docs
- `deps`: Update all deps to latest versions


# v1.8.1

## Fixes
Expand Down
5 changes: 4 additions & 1 deletion cmd/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,10 @@ func informDebug(debugFlag bool) {
if debugModeEnabled {
//zerolog.SetGlobalLevel(zerolog.InfoLevel)
zerolog.SetGlobalLevel(zerolog.DebugLevel)
return
}
// Else no logs should be emitted
zerolog.SetGlobalLevel(zerolog.Disabled)
}

func initLogger() {
Expand Down Expand Up @@ -359,7 +362,7 @@ func outputResult(result interface{}, format string) {
fmt.Println(fmt.Sprintf("%s", result))
}
log.Debug().
Interface("result", result).
Str("result", fmt.Sprintf("%s", result)).
Str("format", format).
Msg(fmt.Sprintf("%s outputResult", DebugFuncExit))
}
Expand Down
5 changes: 3 additions & 2 deletions cmd/storeTypes.go
Original file line number Diff line number Diff line change
Expand Up @@ -636,10 +636,11 @@ func readStoreTypesConfig(fp, gitRef string, gitRepo string, offline bool) (map[
}

func init() {
offline = true // temporarily set to true as it runs before the flag is set
debugFlag = false // temporarily set to false as it runs before the flag is set
offline = true // temporarily set to true as it runs before the flag is set
var gitRef string
var gitRepo string

informDebug(false) // Do not output debug information for initial setup of store-types command
validTypesString := strings.Join(getValidStoreTypes("", DefaultGitRef, DefaultGitRepo), ", ")
offline = false //revert this so that flag is not set to true by default
RootCmd.AddCommand(storeTypesCmd)
Expand Down
Loading
Loading