Skip to content

Conversation

@n7studios
Copy link
Contributor

Summary

Uncode theme tests were failing due to its reliance on an older version of the Options Tree plugin, which incorrectly assumes get_template() always returns a value. This caused our individual End-to-End tests to break when switching themes or deactivating plugins.

To work around this, the two tests were merged into one, ensuring the theme and plugin state remain consistent during the test. This resolves the failures without modifying Uncode itself.

Tests EndToEnd RestrictContentProductThirdPartyThemeOrPageBuilderCest testRestrictContentByProductWithUncodeTheme fail

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Jan 5, 2026
@n7studios n7studios added the bug label Jan 5, 2026
@n7studios n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team January 5, 2026 11:24
@n7studios n7studios marked this pull request as ready for review January 5, 2026 11:24
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

WordPress Playground

🚀 Your PR has been built and is ready for testing in WordPress Playground!

Click here to test your changes in WordPress Playground

Copy link
Contributor

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, these two tests when ran in parallel would sometimes cause failures since one would remove the theme and then the other one would expect it. If so, I'm curious why merging them would solve it because other tests set the theme.

@n7studios
Copy link
Contributor Author

If I understand this correctly, these two tests when ran in parallel would sometimes cause failures since one would remove the theme and then the other one would expect it. If so, I'm curious why merging them would solve it because other tests set the theme.

Honestly, I'm not sure, given the (two) existing tests correctly switch to/from the Uncode theme. I think the Uncode theme isn't the most reliable, and it's not something I particularly want to focus time and resources on, given its limited usage.

Block Refresh: Use Spinner when `ProgressBar` component unavailable
Form Builder: Set Email Field type = `email`
@n7studios n7studios merged commit 2515352 into main Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants