Add beginSslWithClientKey #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvanphp
commented
Oct 16, 2025
Contributor
Author
|
Hey @Links2004, are you ok with this add-on? We really need it for extending the security profiles of OCPP client here: MicroOcpp.cpp#L154-L160 |
Owner
|
dont see a problem with allowing mTLS, but may fix the debug message ;) |
razvanphp
force-pushed
the
add-char-client-key-auth
branch
from
a8c2644 to
53d825b
Compare
Contributor
Author
|
@Links2004 debug messages fixed and aligned. This should be ready to merge, we use it everyday already 🙂 Please tag a release afterwards as well. |
Contributor
Author
|
Thanks @Links2004, please tag a new release so all my PRs can be referenced from pioarduino. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the exact place to put it, in between the gates, but we really need this feature, just let me know where you want it placed.
It is tested and it works great.
Thank you for your work!
PS: related to the discussion in #921
This works using: https://github.com/espressif/arduino-esp32/blob/0dbaa3f0f7ff8c7f7c303fe33555e8cf548acae8/libraries/NetworkClientSecure/src/NetworkClientSecure.cpp#L355-L369