Fixes for searchDialog, RegexHelperDialog, exception logging #477
Annotations
10 warnings
|
Build application:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L190
Modify 'GetTimestamp' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
Build application:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L88
The behavior of 'string.EndsWith(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.GlassfishColumnizer.SplitLine(LogExpert.ILogLineColumnizerCallback, LogExpert.ILogLine)' with a call to 'string.EndsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
|
Build application:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L83
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.GlassfishColumnizer.SplitLine(LogExpert.ILogLineColumnizerCallback, LogExpert.ILogLine)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
|
Build application:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L109
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.SplitLine(ILogLineColumnizerCallback, ILogLine)' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build application:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L162
The behavior of 'string.EndsWith(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.GlassfishColumnizer.GetTimestamp(LogExpert.ILogLineColumnizerCallback, LogExpert.ILogLine)' with a call to 'string.EndsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
|
Build application:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L157
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'GlassfishColumnizer.GlassfishColumnizer.GetTimestamp(LogExpert.ILogLineColumnizerCallback, LogExpert.ILogLine)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
|
Build application:
src/GlassfishColumnizer/GlassfishColumnizer.cs#L152
In member DateTime GlassfishColumnizer.GetTimestamp(ILogLineColumnizerCallback callback, ILogLine logLine), change parameter name logLine to line in order to match the identifier as it has been declared in DateTime ILogLineColumnizer.GetTimestamp(ILogLineColumnizerCallback callback, ILogLine line) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
Build application:
src/ColumnizerLib/IFileSystemPlugin.cs#L42
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.GetLogfileInfo(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.GetLogfileInfo(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
Build application:
src/ColumnizerLib/IFileSystemPlugin.cs#L34
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.CanHandleUri(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.CanHandleUri(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
Build application:
src/ColumnizerLib/LineEntry.cs#L22
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
|
Loading