514 loading as session file leads to broken UI if a log file in session is not found #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…broken-ui-if-a-log-file-in-session-is-not-found
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…-file-in-session-is-not-found' of https://github.com/LogExperts/LogExpert into 514-loading-as-session-file-leads-to-broken-ui-if-a-log-file-in-session-is-not-found
Comment on lines
+105
to
+111
| foreach (var filePath in fileNames.Select(fileName => Path.Join(_testDirectory, fileName))) | ||
| { | ||
| if (File.Exists(filePath)) | ||
| { | ||
| File.Delete(filePath); | ||
| } | ||
| } |
Comment on lines
+202
to
+209
| foreach (var drive in driveLetters.Where(drive => drive != originalDrive && !string.IsNullOrEmpty(pathWithoutDrive))) | ||
| { | ||
| var alternatePath = $"{drive}:\\{pathWithoutDrive}"; | ||
| if (File.Exists(alternatePath) && !alternatives.Contains(alternatePath)) | ||
| { | ||
| alternatives.Add(alternatePath); | ||
| } | ||
| } |
Hirogen
deleted the
514-loading-as-session-file-leads-to-broken-ui-if-a-log-file-in-session-is-not-found
branch
This was
linked to
issues
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new utilities for managing and validating project file references, especially in the context of handling
.lxppersistence files and improving file history and error handling. The changes add robust helpers for resolving, validating, and mapping project file references, provide mechanisms for suggesting alternative file locations, and improve error resilience in file operations.Key changes include new helpers for file resolution and validation, improvements to project file loading, and enhanced error handling.
Project File Resolution & Validation
ProjectFileResolverandProjectFileValidatorutility classes to resolve project file references (including.lxppersistence files) to actual log files and to validate file existence, suggest alternatives, and handle plugin-based file systems. (src/LogExpert.Core/Classes/Persister/ProjectFileResolver.cs[1]src/LogExpert.Core/Classes/Persister/ProjectFileValidator.cs[2]ProjectLoadResultto encapsulate project loading results, including validation status, mappings from log files to original references, and user intervention flags. (src/LogExpert.Core/Classes/Persister/ProjectLoadResult.cssrc/LogExpert.Core/Classes/Persister/ProjectLoadResult.csR1-R35)Project Persistence and Data Model
ProjectPersister.LoadProjectDatato use the new validation and resolution helpers, returning aProjectLoadResultinstead of rawProjectData. (src/LogExpert.Core/Classes/Persister/ProjectPersister.cs[1] [2]ProjectDatato include aProjectFilePathproperty for improved context in file validation and alternative search. (src/LogExpert.Core/Classes/Persister/ProjectData.cssrc/LogExpert.Core/Classes/Persister/ProjectData.csR18-R22)File Reference Resolution Helpers
PersisterHelperswith methods to resolve.lxpsettings files to their contained log file paths, supporting plugin-based file systems and collections of file names. (src/LogExpert.Core/Classes/Persister/PersisterHelpers.cssrc/LogExpert.Core/Classes/Persister/PersisterHelpers.csR1-R71)Configuration and Error Handling Improvements
JsonSerializationException,FileNotFoundException) in catch blocks. (src/LogExpert.Configuration/ConfigManager.cs[1]src/LogExpert.Core/Classes/Persister/PersisterXML.cs[2]ConfigManager, including limiting history size and clearing the last open files list. (src/LogExpert.Configuration/ConfigManager.cs[1] [2]These changes collectively make project file handling more robust, user-friendly, and extensible, especially in environments with diverse file systems and potential for missing or relocated files.