Random state UMAP and output for make_cloud #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
dedenseras a python package, I noticed the needed for some modifications.umapimplementation onmake_clouddoes not have a fixedrandom_state, causing different downsampling outcomes when repeatedly calling the function andDedenser.downsample()on the same dataset. I added a random seed for umap.outputoption onmake_cloud, which allows returning the point cloud array for direct use inDedenser.downsample(). The array is still saved to file.minimal example: