ci: Fix docker compose timeout behavior #34628
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--timeout=0 used to mean "kill immediately", but since we upgraded Docker Compose it seems to have changed meaning to "wait forever"
Seen in https://buildkite.com/materialize/test/builds/113972#019b6fa9-0fda-41ce-8c36-5be94fa1c0f5
I haven't found any changelog or documentation explaining this change, so it might be an unintentional change. Locally I can reproduce that
--timeout=0is no longer fast. I'm not sure yet if this is a definitive fix, otherwise we might need another workaround.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.