<fix>[storage]: when the snapshot group creation fails, delete the successfully created snapshots #2928

zstack-robot-1 · 2025-11-20T02:25:43Z

Resolves: ZSV-9792

Change-Id: I6b65736e646e7163777a7872667077756771726d

sync from gitlab !8330

<fix>[conf]: fix sql error when set ipInBinary See merge request zstackio/zstack!8284

VmDiskSpec is used to create DiskAO. Related: ZSV-9750 Related: ZSV-8585 Change-Id: I776c6b63667a70716b6769696c716667656e7865

<test>[testlib]: introduce VmDiskSpec See merge request zstackio/zstack!8286

replace dataVolumeSystemTagsOnIndex by deprecatedDisksSpecs Related: ZSV-9750 Related: ZSV-8585 Change-Id: I6c6e7464786379726b75796c78647577626a7a61

<fix>[compute]: try to remove dataVolumeSystemTagsOnIndex See merge request zstackio/zstack!8287

merge VmInstanceSpec.dataDiskOfferingUuids to VmInstanceSpec.deprecatedDiskSpec Related: ZSV-9750 Related: ZSV-8585 Change-Id: I6e646178667163786b64766c766461726d777676

Related: ZSV-5936 Change-Id: I6d6e7a72756a657572696a616470766178616e62

<fix>[core]: fix QueryMore "notIn" methods See merge request zstackio/zstack!8296

<fix>[compute]: try to remove dataVolumeSystemTagsOnIndex See merge request zstackio/zstack!8292

Related: ZSV-5936 Related: ZSTAC-75573 Change-Id: I736867626c7a6b6c76647363627765726b6d7375

Related: ZSV-5936 Related: ZSTAC-69257 Change-Id: I6168766a75786d65736f72697267736e716f717a

Remove modules list below: * baremetal2 * hybrid * mini * mini-storage * aliyun-storage * aliyun-proxy Related: ZSV-5936 Change-Id: I7a7571787968787770696c616170617361626a79

<fix>[compute]: fix IllegalStateException in HostOsVersionAllocatorFlow See merge request zstackio/zstack!8311

<fix>[conf]: add lun missing error xml See merge request zstackio/zstack!8310

<fix>[build]: remove deprecated modules See merge request zstackio/zstack!8297

rewrite cases list below: * BootModeCase * SystemTagCase To avoid deprecated resource / action: * instance offering * disk offering Related: ZSV-5936 Change-Id: I65747a726767657a797467706d6d6d7074716972

Related: ZSV-5936 Change-Id: I6e69756b79696177727764777a616d636c796679

<test>[configuration]: rewrite deprecated cases See merge request zstackio/zstack!8323

rewrite cases list below: * ConsoleProxyCase * DatabaseWrapperCase To avoid deprecated resource / action: * instance offering * disk offering Related: ZSV-5936 Change-Id: I64747a676d6b6e7073657278707264636a796375

rewrite cases list below: * InvalidDeleteResourceCase * AccountCase * OperationResourceCase * DelayDeleteResourceCase * DeleteNormalAccountCase To avoid deprecated resource / action: instance offering disk offering Related: ZSV-5936 Change-Id: I617a7a687176746e796b7865796a6a7964707a6a

rewrite cases list below: * DeleteIsoCase * ImageOperationsCase * LinuxImagePlatformOtherHotPluginVolumeCase * AddImageToCephBackStorageCase * AddImageToSftpBackStorageCase * CreateRootVolumeTemplateFromVolumeSnapshotCase To avoid deprecated resource / action: instance offering disk offering Related: ZSV-5936 Change-Id: I6d6e67707a707266726c7274646d7a72646a6c65

<test>[configuration]: rewrite deprecated cases See merge request zstackio/zstack!8326

Resolves: ZSV-9791 Related: ZSV-9750 Related: ZSV-8585 Change-Id: I73716165686d6b7376627178616d65796d676c76

"driver::virtio" is tag for VmInstanceVO (not for VolumeVO) Related: ZSV-9791 Related: ZSV-8585 Change-Id: I66726575787a68747a666c666c7a746d6c6e6d63

<test>[configuration]: rewrite deprecated cases See merge request zstackio/zstack!8325

Resolves: ZSV-8585 Change-Id: I766b6f7462716f6a6a666161697377616a636875

<fix>[compute]: support CreateVmInstanceAction.diskAO.systemTags See merge request zstackio/zstack!8329

<fix>[compute]: support CreateVmInstanceAction.diskAO.systemTags See merge request zstackio/zstack!8321

To avoid deprecated resource / action: * CreateVmInstanceAction.dataVolumeSystemTagsOnIndex Resolves: ZSV-9750 Related: ZSV-5936 Change-Id: I767078716e666f6d6d686a6c7a626a7a6a666e74

rewrite cases list below: * CreateVmWithVolumeTagsCase To avoid deprecated resource / action: * instance offering * disk offering * CreateVmInstanceAction.dataVolumeSystemTags Resolves: ZSV-9750 Related: ZSV-5936 Change-Id: I787a767478746e69757167616377737665647a65

<fix>[zsv]: support check ecph plugin See merge request zstackio/zstack!8659

<fix>[softwarePackage]: add APIQuerySoftwarePackageMsg See merge request zstackio/zstack!8665

<fix>[ceph]: correctly roll back CephOsdGroupVO availableCapacity See merge request zstackio/zstack!8666

<fix>[sdk]: support multi client config See merge request zstackio/zstack!8660

Resolves: ZSV-9928 Change-Id: I68797276687a787861676d796f717370756a7a6a

Resolves: ZSTAC-78105 Resolves: ZSV-9883 Change-Id: I716563666c6e7862736b6a65766f6e6674786970

<fix>[zbs]: zbs support getting active clients See merge request zstackio/zstack!8521

GlobalPropertyImpact Resolves: ZSTAC-71011 Resolves: ZSV-8897 Change-Id: I6964747463626a6568656e786a6f6a747877747a

Resolves: ZSTAC-74569 Resolves: ZSV-8903 Change-Id: I797465707a7473757478727a7a7867637a6c736c

Resolves: ZSTAC-79068 Resolves: ZSV-10070 Change-Id: I756665756a717964756f666968637664646c6e61

<fix>[plugin]: support for batch volume query See merge request zstackio/zstack!8675

<fix>[storage]: zbs support cdp See merge request zstackio/zstack!8674

support sudo with complex password Resolves: ZSV-9923 Related: ZSTAC-69124 Change-Id: I75616d756c786f697673716c6372766f67766467

<fix>[zbs]: decrease db info reload times See merge request zstackio/zstack!8676

<fix>[ansible]: enhance Ssh tools See merge request zstackio/zstack!8680

Resolves: ZSV-9923 Related: ZSTAC-69124 Change-Id: I616e64727376796e696d6f6779776e7378727076

<fix>[ansible]: fix host pswd shell See merge request zstackio/zstack!8685

ScriptRunner is also a SshRunner Related: ZSV-9923 Change-Id: I7372726375776768756b796f636a646b706b6f70

stdout and stderr will both write into ssh output Resolves: ZSV-9923 Related: ZSTAC-69124 Change-Id: I6b68767166687072756e64776d6d6377746a6a6a

SshShell will merge to Ssh as a "local-bash-ssh" mode Ssh scripts runner Related: ZSV-9923 Change-Id: I7067636d67736470757279726f73667277746668

<fix>[utils]: enhance Ssh tools See merge request zstackio/zstack!8688

<feature>[softwarePackage]: add APIUninstallSoftwarePackageMsg See merge request zstackio/zstack!8657

Resolves: ZSV-9208 Related: ZSTAC-65490 Change-Id: I7778654901646874706164777869707679736172

Resolves: ZSV-9700 Related: ZSTAC-66709 Change-Id: I6e65727673676f7369756b626f6a6270736e7777

<fix>[root]: upgrade spring security to 5.7.13 See merge request zstackio/zstack!8691

<fix>[crypto]: fix encryption image cache error See merge request zstackio/zstack!8690

Related: ZSV-9923 Change-Id: I777a76716573736b746f736c6c6e71766f776a69

<fix>[utils]: fix error in scp upload See merge request zstackio/zstack!8693

…ccessfully created snapshots Resolves: ZSV-9792 Change-Id: I6b65736e646e7163777a7872667077756771726d

coderabbitai · 2025-11-20T02:26:09Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

77 files out of 284 files are above the max files limit of 200.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch sync/tao.gan/ZSV-9792@@2

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gitlab and others added 30 commits August 22, 2025 12:18

Merge branch 'ZSV-9771-fix' into 'zsv_4.10.20'

74946e6

<fix>[conf]: fix sql error when set ipInBinary See merge request zstackio/zstack!8284

<test>[testlib]: introduce VmDiskSpec

db38b98

VmDiskSpec is used to create DiskAO. Related: ZSV-9750 Related: ZSV-8585 Change-Id: I776c6b63667a70716b6769696c716667656e7865

Merge branch 'zsv-1' into 'zsv_4.10.20'

e20b738

<test>[testlib]: introduce VmDiskSpec See merge request zstackio/zstack!8286

<fix>[compute]: try to remove dataVolumeSystemTagsOnIndex

51cb2f2

replace dataVolumeSystemTagsOnIndex by deprecatedDisksSpecs Related: ZSV-9750 Related: ZSV-8585 Change-Id: I6c6e7464786379726b75796c78647577626a7a61

Merge branch 'zsv-2' into 'zsv_4.10.20'

bbec650

<fix>[compute]: try to remove dataVolumeSystemTagsOnIndex See merge request zstackio/zstack!8287

<fix>[compute]: try to remove dataDiskOfferingUuids in VmInstanceSpec

4f1a770

merge VmInstanceSpec.dataDiskOfferingUuids to VmInstanceSpec.deprecatedDiskSpec Related: ZSV-9750 Related: ZSV-8585 Change-Id: I6e646178667163786b64766c766461726d777676

<fix>[core]: fix QueryMore "notIn" methods

8e131d9

Related: ZSV-5936 Change-Id: I6d6e7a72756a657572696a616470766178616e62

Merge branch 'zsv-5' into 'zsv_4.10.20'

f3ed776

<fix>[core]: fix QueryMore "notIn" methods See merge request zstackio/zstack!8296

Merge branch 'zsv-1@@2' into 'zsv_4.10.20'

303854e

<fix>[compute]: try to remove dataVolumeSystemTagsOnIndex See merge request zstackio/zstack!8292

<fix>[conf]: add lun missing error xml

fbe468e

Related: ZSV-5936 Related: ZSTAC-75573 Change-Id: I736867626c7a6b6c76647363627765726b6d7375

<fix>[compute]: fix IllegalStateException in HostOsVersionAllocatorFlow

3b6999e

Related: ZSV-5936 Related: ZSTAC-69257 Change-Id: I6168766a75786d65736f72697267736e716f717a

<fix>[build]: remove deprecated modules

95d8513

Remove modules list below: * baremetal2 * hybrid * mini * mini-storage * aliyun-storage * aliyun-proxy Related: ZSV-5936 Change-Id: I7a7571787968787770696c616170617361626a79

Merge branch 'zsv-7' into 'zsv_4.10.20'

600e170

<fix>[compute]: fix IllegalStateException in HostOsVersionAllocatorFlow See merge request zstackio/zstack!8311

Merge branch 'zsv-5@@2' into 'zsv_4.10.20'

dae4426

<fix>[conf]: add lun missing error xml See merge request zstackio/zstack!8310

Merge branch 'zsv-3@@2' into 'zsv_4.10.20'

f51878d

<fix>[build]: remove deprecated modules See merge request zstackio/zstack!8297

<test>[configuration]: rewrite deprecated cases

ed09f6c

rewrite cases list below: * BootModeCase * SystemTagCase To avoid deprecated resource / action: * instance offering * disk offering Related: ZSV-5936 Change-Id: I65747a726767657a797467706d6d6d7074716972

<fix>[tag]: enhance tag error printing

f04a145

Related: ZSV-5936 Change-Id: I6e69756b79696177727764777a616d636c796679

Merge branch 'zsv-3' into 'zsv_4.10.20'

6f1a586

<test>[configuration]: rewrite deprecated cases See merge request zstackio/zstack!8323

<test>[configuration]: rewrite deprecated cases

394cc90

rewrite cases list below: * ConsoleProxyCase * DatabaseWrapperCase To avoid deprecated resource / action: * instance offering * disk offering Related: ZSV-5936 Change-Id: I64747a676d6b6e7073657278707264636a796375

Merge branch 'zsv-6' into 'zsv_4.10.20'

5ee5714

<test>[configuration]: rewrite deprecated cases See merge request zstackio/zstack!8326

<fix>[compute]: support CreateVmInstanceAction.diskAO.systemTags

b1a2816

Resolves: ZSV-9791 Related: ZSV-9750 Related: ZSV-8585 Change-Id: I73716165686d6b7376627178616d65796d676c76

<fix>[compute]: clean "driver::virtio" tag when validate CreateVmAction

e7d52ca

"driver::virtio" is tag for VmInstanceVO (not for VolumeVO) Related: ZSV-9791 Related: ZSV-8585 Change-Id: I66726575787a68747a666c666c7a746d6c6e6d63

Merge branch 'zsv-5' into 'zsv_4.10.20'

9d03c53

<test>[configuration]: rewrite deprecated cases See merge request zstackio/zstack!8325

<fix>[compute]: split diskAO to rootDisk and dataDisks

f4c5524

Resolves: ZSV-8585 Change-Id: I766b6f7462716f6a6a666161697377616a636875

Merge branch 'zsv-3@@2' into 'zsv_4.10.20'

39690a4

<fix>[compute]: support CreateVmInstanceAction.diskAO.systemTags See merge request zstackio/zstack!8329

Merge branch 'zsv-2@@2' into 'zsv_4.10.20'

6916c8e

<fix>[compute]: support CreateVmInstanceAction.diskAO.systemTags See merge request zstackio/zstack!8321

<test>[testlib]: remove deprecated parameters in VmSpec

e703967

To avoid deprecated resource / action: * CreateVmInstanceAction.dataVolumeSystemTagsOnIndex Resolves: ZSV-9750 Related: ZSV-5936 Change-Id: I767078716e666f6d6d686a6c7a626a7a6a666e74

gitlab and others added 29 commits November 7, 2025 09:20

Merge branch 'check-ZSV-9928@@2' into 'zsv_4.10.20'

afb247b

<fix>[zsv]: support check ecph plugin See merge request zstackio/zstack!8659

Merge branch 'query-softwarepackage-ZSV-9928@@2' into 'zsv_4.10.20'

70757ee

<fix>[softwarePackage]: add APIQuerySoftwarePackageMsg See merge request zstackio/zstack!8665

Merge branch 'ZSV-10425@@2' into 'zsv_4.10.20'

2fafd25

<fix>[ceph]: correctly roll back CephOsdGroupVO availableCapacity See merge request zstackio/zstack!8666

Merge branch 'ZSV-10416' into 'zsv_4.10.20'

c787fd7

<fix>[sdk]: support multi client config See merge request zstackio/zstack!8660

<feature>[softwarePackage]: add APIUninstallSoftwarePackageMsg

2b169df

Resolves: ZSV-9928 Change-Id: I68797276687a787861676d796f717370756a7a6a

<fix>[zbs]: zbs support getting active clients

ec4b21e

Resolves: ZSTAC-78105 Resolves: ZSV-9883 Change-Id: I716563666c6e7862736b6a65766f6e6674786970

Merge branch 'ZSV-9883@@3' into 'zsv_4.10.20'

11b81a8

<fix>[zbs]: zbs support getting active clients See merge request zstackio/zstack!8521

<fix>[storage]: zbs support cdp

2795fa4

GlobalPropertyImpact Resolves: ZSTAC-71011 Resolves: ZSV-8897 Change-Id: I6964747463626a6568656e786a6f6a747877747a

<fix>[plugin]: support for batch volume query

61fcdc8

Resolves: ZSTAC-74569 Resolves: ZSV-8903 Change-Id: I797465707a7473757478727a7a7867637a6c736c

<fix>[zbs]: decrease db info reload times

555b55e

Resolves: ZSTAC-79068 Resolves: ZSV-10070 Change-Id: I756665756a717964756f666968637664646c6e61

Merge branch 'ZSV-8903@@2' into 'zsv_4.10.20'

1b03ee3

<fix>[plugin]: support for batch volume query See merge request zstackio/zstack!8675

Merge branch 'ZSV-8897@@3' into 'zsv_4.10.20'

ed3f4c7

<fix>[storage]: zbs support cdp See merge request zstackio/zstack!8674

<fix>[ansible]: enhance Ssh tools

8e35214

support sudo with complex password Resolves: ZSV-9923 Related: ZSTAC-69124 Change-Id: I75616d756c786f697673716c6372766f67766467

Merge branch 'ZSV-10070' into 'zsv_4.10.20'

94a257c

<fix>[zbs]: decrease db info reload times See merge request zstackio/zstack!8676

Merge branch 'zsv-3@@2' into 'zsv_4.10.20'

6c510c5

<fix>[ansible]: enhance Ssh tools See merge request zstackio/zstack!8680

<fix>[ansible]: fix host pswd shell

717aa37

Resolves: ZSV-9923 Related: ZSTAC-69124 Change-Id: I616e64727376796e696d6f6779776e7378727076

Merge branch 'zsv-3' into 'zsv_4.10.20'

d14d797

<fix>[ansible]: fix host pswd shell See merge request zstackio/zstack!8685

<fix>[utils]: enhance Ssh tools

af76b9b

ScriptRunner is also a SshRunner Related: ZSV-9923 Change-Id: I7372726375776768756b796f636a646b706b6f70

<fix>[ansible]: fix sudo password echo

7483da2

stdout and stderr will both write into ssh output Resolves: ZSV-9923 Related: ZSTAC-69124 Change-Id: I6b68767166687072756e64776d6d6377746a6a6a

<chore>[utils]: add TODO for refactoring SshShell

9c76caf

SshShell will merge to Ssh as a "local-bash-ssh" mode Ssh scripts runner Related: ZSV-9923 Change-Id: I7067636d67736470757279726f73667277746668

Merge branch 'zsv-3' into 'zsv_4.10.20'

0b4a30b

<fix>[utils]: enhance Ssh tools See merge request zstackio/zstack!8688

Merge branch 'uninstall-storate-ZSV-9928@@2' into 'zsv_4.10.20'

99e8c9d

<feature>[softwarePackage]: add APIUninstallSoftwarePackageMsg See merge request zstackio/zstack!8657

<fix>[crypto]: fix encryption image cache error

4d21c85

Resolves: ZSV-9208 Related: ZSTAC-65490 Change-Id: I7778654901646874706164777869707679736172

<fix>[root]: upgrade spring security to 5.7.13

c8d93de

Resolves: ZSV-9700 Related: ZSTAC-66709 Change-Id: I6e65727673676f7369756b626f6a6270736e7777

Merge branch 'zsv-0' into 'zsv_4.10.20'

52dbf1e

<fix>[root]: upgrade spring security to 5.7.13 See merge request zstackio/zstack!8691

Merge branch 'zsv-8@@2' into 'zsv_4.10.20'

bf779c3

<fix>[crypto]: fix encryption image cache error See merge request zstackio/zstack!8690

<fix>[utils]: fix error in scp upload

7e05ce9

Related: ZSV-9923 Change-Id: I777a76716573736b746f736c6c6e71766f776a69

Merge branch 'zsv-4' into 'zsv_4.10.20'

40382ed

<fix>[utils]: fix error in scp upload See merge request zstackio/zstack!8693

<fix>[storage]: when the snapshot group creation fails, delete the su…

632d824

…ccessfully created snapshots Resolves: ZSV-9792 Change-Id: I6b65736e646e7163777a7872667077756771726d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

<fix>[storage]: when the snapshot group creation fails, delete the successfully created snapshots #2928

<fix>[storage]: when the snapshot group creation fails, delete the successfully created snapshots #2928

Uh oh!

zstack-robot-1 commented Nov 20, 2025

Uh oh!

coderabbitai bot commented Nov 20, 2025

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

<fix>[storage]: when the snapshot group creation fails, delete the successfully created snapshots #2928

Are you sure you want to change the base?

<fix>[storage]: when the snapshot group creation fails, delete the successfully created snapshots #2928

Uh oh!

Conversation

zstack-robot-1 commented Nov 20, 2025

Uh oh!

coderabbitai bot commented Nov 20, 2025

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants