Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Jan 9, 2026

The grouped dependency updates were causing Dependabot to fail with:

  • "peer dependencies are incorrectly met" errors
  • "Couldn't find the node_modules state file" errors

This commit removes all dependency groups and switches to a simpler configuration pattern that is proven to work with Yarn 4 workspaces, based on the working configuration in MetaMask/core.

Changes:

  • Remove all 10 dependency groups (vite, metamask, react, etc.)
  • Add 'allow' lists for high-priority packages (@metamask/, @agoric/, @endo/*)
  • Add github-actions ecosystem monitoring
  • Keep weekly schedule and other working settings

Trade-off: Will receive more individual PRs instead of grouped ones, but Dependabot will (hopefully) actually work and be able to update dependencies.


Note

Dependabot config simplified for Yarn 4 workspaces

  • Removes all dependency groups and the target-branch setting from .github/dependabot.yml
  • Adds an allow list for @metamask/*, @agoric/*, and @endo/*
  • Introduces a github-actions ecosystem with a weekly schedule
  • Retains weekly schedule, increase-if-necessary versioning, and PR limits

Written by Cursor Bugbot for commit c008365. This will update automatically on new commits. Configure here.

@rekmarks rekmarks requested a review from a team as a code owner January 9, 2026 20:55
The grouped dependency updates were causing Dependabot to fail with:
- "peer dependencies are incorrectly met" errors
- "Couldn't find the node_modules state file" errors

This commit removes all dependency groups and switches to a simpler
configuration pattern that is proven to work with Yarn 4 workspaces,
based on the working configuration in MetaMask/core.

Changes:
- Remove all 10 dependency groups (vite, metamask, react, etc.)
- Add 'allow' lists for high-priority packages (@metamask/*, @agoric/*, @endo/*)
- Add github-actions ecosystem monitoring
- Keep weekly schedule and other working settings

Trade-off: Will receive more individual PRs instead of grouped ones,
but Dependabot will actually work and be able to update dependencies.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@rekmarks rekmarks force-pushed the rekm/fix-dependabot branch from 9caa57e to 285b8e4 Compare January 9, 2026 20:56
@rekmarks rekmarks enabled auto-merge (squash) January 9, 2026 20:56
allow:
- dependency-name: '@metamask/*'
- dependency-name: '@agoric/*'
- dependency-name: '@endo/*'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package ses excluded from new allow list

Medium Severity

The ses package was explicitly included in the original agoric group alongside @agoric/* and @endo/*, but it's missing from the new allow list. Since ses is a standalone package without a namespace prefix, it won't match @agoric/* or @endo/* patterns. This means the ses package will no longer receive version updates, even though it's part of the same ecosystem the configuration intends to monitor.

Fix in Cursor Fix in Web

Copy link
Contributor

@grypez grypez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proven to work in MetaMask/core SGTM

@rekmarks rekmarks merged commit 230343d into main Jan 9, 2026
28 checks passed
@rekmarks rekmarks deleted the rekm/fix-dependabot branch January 9, 2026 21:32
@FUDCo
Copy link
Contributor

FUDCo commented Jan 9, 2026

Wondering if cursor bot may have been onto something there...

@rekmarks
Copy link
Member Author

rekmarks commented Jan 9, 2026

Ah, shoot, yes it was. Will fix.

rekmarks added a commit that referenced this pull request Jan 9, 2026
Restores `ses` as an allowed dependency to update in the Dependabot config after it was accidentally removed in #729.
rekmarks added a commit that referenced this pull request Jan 10, 2026
Restores `ses` as an allowed dependency to update in the Dependabot
config after it was accidentally removed in #729.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Restores Dependabot updates for the `ses` package.
> 
> - Adds `ses` to the `allow` list in `.github/dependabot.yml` under the
npm ecosystem
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
0145bb7. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants