-
Notifications
You must be signed in to change notification settings - Fork 62
[Diagnostics] Add Crashpad folder to diagnostic script #5469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Diagnostics] Add Crashpad folder to diagnostic script #5469
Conversation
2851d02 to
51c38bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the WebView2 diagnostic log collection script to automatically locate and include Crashpad folder contents (crash dumps and metadata) in the diagnostic ZIP file. The changes enable automatic detection of WebView2 processes to find crash data, with fallback manual override options.
- Adds automatic WebView2 process detection to locate Crashpad folders
- Introduces new optional parameters for process filtering and manual directory specification
- Updates ZIP creation to recursively include all Crashpad folder contents
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| diagnostics/script.md | Documents new ExeName and userDataDir parameters and describes Crashpad folder collection |
| diagnostics/resources/log_collection_script.ps1 | Implements Crashpad folder detection, process filtering, and ZIP packaging of crash data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Look for Crashpad folder | ||
| $crashpadFolder = "" | ||
| $folderToCheck = "" | ||
| $uniqueUserDataFolders = @() |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name 'uniqueUserDataFolders' is misleading as it's not actually storing unique folders from multiple processes. The code only stores a single folder and breaks after finding the first match. Consider renaming to 'userDataFolder' (singular) or 'foundUserDataFolder' to better reflect that it only contains one folder path, not multiple unique folders.
gourabkmsft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary
Enhanced the WebView2 diagnostic log collection script to automatically locate and include the entire Crashpad folder in the diagnostic ZIP file. This improves crash troubleshooting by capturing all crash reports and metadata in one collection.
Changes