Resolve null location check (possibly specifically on Folia) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @Phoenix616, just wanted to notify you in case you missed this! |
Phoenix616
requested changes
Dec 21, 2025
Member
Phoenix616
left a comment
Phoenix616
left a comment
There was a problem hiding this comment.
Thanks for reminding me, I guess I forgot to comment on this when I originally looked at it.
Please reduce the diff of your PR to only include the actual logic changes, changing the formatting of basically every file makes it impossible to review (and should be done in a separate commit too to keep the commit history clean)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Folia, I noticed unsuccessful searches as a result of:
https://mclo.gs/G6HXcVs
This PR seemingly fixes this and ensures that searches are more successful. As per usual, if you have any required or preferred fixes, don't hesitate to let me know!