Skip to content

Conversation

Copy link

Copilot AI commented Dec 25, 2025

Hub75 LED matrix types (values 101-108) were incorrectly shown in LED type dropdowns for outputs added via the "+" button when builds lacked WLED_ENABLE_HUB75MATRIX support. First output filtered correctly; subsequent ones did not.

Changes

  • wled00/data/settings_leds.htm: Call hideHub75() after inserting new LED output HTML in addLEDs() function

The existing hideHub75() function removes Hub75 options from all LED type selects when Hub75 support is not compiled in. It was only invoked on page load by the backend, missing dynamically created outputs.

function addLEDs(n,init=true) {
  // ... HTML insertion code ...
  f.insertAdjacentHTML("beforeend", cn);
  hideHub75(); // remove Hub75 options if not supported
}

Screenshot

LED type dropdown after adding new output (Hub75 options correctly excluded):

Dropdown without Hub75

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • wled00
    • Triggering command: /usr/local/bin/node node tools/cdata.js (dns block)
    • Triggering command: /usr/local/bin/node node tools/cdata.js --force (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Hub75 shown in output list incorrectly</issue_title>
<issue_description>For builds without hub75 support, it should not be listed in the led type drop-down. This works currently for the first output, but it's incorrectly included for the later outputs </issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link

coderabbitai bot commented Dec 25, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Call hideHub75() after dynamically adding new LED outputs to ensure Hub75 options are removed when Hub75 support is not compiled in.

Co-authored-by: netmindz <442066+netmindz@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incorrect inclusion of hub75 in output list Fix Hub75 options appearing in dynamically added LED outputs Dec 25, 2025
Copilot AI requested a review from netmindz December 25, 2025 10:10
@netmindz netmindz marked this pull request as ready for review December 25, 2025 10:11
@softhack007
Copy link
Collaborator

there is another PR that seems to do the same

which one is correct? or both work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hub75 shown in output list incorrectly

3 participants