feat: .gitignore file will handle ** pattern properly in Glob.

[Eric-Guo]

Related Issue

Resolve #368

Description

ripgrep will handle .gitignore properly, so no need extra limit here.

[Copilot]

Pull request overview

This PR modifies the glob tool to allow recursive ** patterns when a .gitignore file exists in the search directory. The assumption is that .gitignore will constrain the search to prevent performance issues from scanning large directories like node_modules.

Key Changes:

• Modified pattern validation to check for .gitignore file presence before rejecting ** patterns
• Updated error messages to explain why ** patterns are blocked (when no .gitignore exists)
• Added test coverage for the new behavior allowing ** patterns with .gitignore

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/kimi_cli/tools/file/glob.py	Added .gitignore check in _validate_pattern to allow ** patterns when .gitignore exists; updated parameter signature and error messages
tests/test_glob.py	Added new test case verifying that ** patterns are allowed when .gitignore file is present

Comments suppressed due to low confidence (2)

src/kimi_cli/tools/file/glob.py:90

• The pattern validation is checking for .gitignore in self._work_dir, but this happens before determining the actual search directory (dir_path). If a user specifies a subdirectory with its own .gitignore file, the validation won't find it because it's only looking in the work directory.

Consider this scenario:

• Work dir: /project (no .gitignore)
• Search dir: /project/subdir (has .gitignore)
• Pattern: **/*.py

The current code will reject the pattern because it checks /project/.gitignore before determining that the actual search directory is /project/subdir.

The validation should check for .gitignore in the directory that will actually be searched. Move the pattern validation after determining dir_path, and pass dir_path instead of self._work_dir to _validate_pattern.

            pattern_error = await self._validate_pattern(params.pattern, self._work_dir)
            if pattern_error:
                return pattern_error

            dir_path = KaosPath(params.directory) if params.directory else self._work_dir

src/kimi_cli/tools/file/glob.py:61

• The error message says "the working directory does not contain a .gitignore" but this may be inaccurate if the user is searching a subdirectory. The message should refer to "the search directory" instead to be accurate in all cases.

Suggested change:

f"Pattern `{pattern}` starts with '**' which is not allowed because "
"the search directory does not contain a .gitignore to constrain the search. "

Additionally, line 61 mentions "working directory" but should refer to "search directory" to match the actual directory being listed.

                    f"Pattern `{pattern}` starts with '**' which is not allowed because "
                    "the working directory does not contain a .gitignore to constrain the search. "
                    "This would recursively search all directories and may include large "
                    "directories like `node_modules`. Use more specific patterns instead. "
                    "For your convenience, a list of all files and directories in the "
                    "top level of the working directory is provided below."

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[stdrc]

I really appreciate your effort and passion but the tool you changed is Glob, not Grep.🤣

[Eric-Guo]

Yeah, just realize the AI recognized async for match in dir_path.glob(params.pattern): in glob.py to rg.glob in grep_local.py, actually it should be kaos package, will continue dig the rabbit hole.

[Eric-Guo]

@stdrc Kindly take a look and feel free to implement your version.

Glade to know the kosong and pykao now part of the repo.