Skip to content

Conversation

@milov-dmitriy
Copy link
Collaborator

@milov-dmitriy milov-dmitriy commented Dec 19, 2025

Сначала собираем образы, затем их используем.

Задача: 1067

@milov-dmitriy milov-dmitriy force-pushed the refactor_git_checks_task_1067 branch from 938581d to 95a03c4 Compare December 19, 2025 08:38
@milov-dmitriy milov-dmitriy force-pushed the refactor_git_checks_task_1067 branch from 95a03c4 to 51f7e92 Compare December 19, 2025 08:42
@milov-dmitriy milov-dmitriy self-assigned this Dec 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the GitHub Actions workflow to optimize Docker image builds for linting tasks. Instead of building the linter image separately in each job, the workflow now builds it once in a dedicated job and pushes it to the GitHub Container Registry, with subsequent jobs pulling and reusing that image.

Key Changes:

  • Introduced a build_linters job that builds and pushes the linter Docker image once
  • Modified ruff_linter, ruff_format, and mypy jobs to depend on build_linters and pull the pre-built image
  • Added repository name downcasing to ensure Docker tag compatibility

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
interface Updated subproject commit reference
.github/workflows/checks.yml Refactored linting workflow to build Docker image once and reuse across jobs, eliminating redundant builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@milov-dmitriy milov-dmitriy force-pushed the refactor_git_checks_task_1067 branch from b3df88d to 806161a Compare December 19, 2025 09:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@milov-dmitriy milov-dmitriy force-pushed the refactor_git_checks_task_1067 branch from d77b00e to d37aa64 Compare December 22, 2025 09:23
@milov-dmitriy milov-dmitriy changed the title Refactor: git checks task_1067 Refactor: git checks Dec 24, 2025
@milov-dmitriy milov-dmitriy merged commit b72d767 into dev Dec 24, 2025
6 checks passed
@milov-dmitriy milov-dmitriy deleted the refactor_git_checks_task_1067 branch December 24, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants