-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor: git checks #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: git checks #869
Conversation
938581d to
95a03c4
Compare
95a03c4 to
51f7e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the GitHub Actions workflow to optimize Docker image builds for linting tasks. Instead of building the linter image separately in each job, the workflow now builds it once in a dedicated job and pushes it to the GitHub Container Registry, with subsequent jobs pulling and reusing that image.
Key Changes:
- Introduced a
build_lintersjob that builds and pushes the linter Docker image once - Modified
ruff_linter,ruff_format, andmypyjobs to depend onbuild_lintersand pull the pre-built image - Added repository name downcasing to ensure Docker tag compatibility
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| interface | Updated subproject commit reference |
| .github/workflows/checks.yml | Refactored linting workflow to build Docker image once and reuse across jobs, eliminating redundant builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b3df88d to
806161a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d77b00e to
d37aa64
Compare
Сначала собираем образы, затем их используем.
Задача: 1067