Skip to content

Conversation

@Mastermind-U
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the first working version for GSSAPI integration into the LDAP client using SASL bind, providing necessary dependency updates, example usage, and Docker configuration.

  • Added the "gssapi" dependency in pyproject.toml.
  • Introduced a new gssapi_example function in main.py demonstrating GSSAPI usage.
  • Updated aioldap3.py with SASL GSSAPI support and integrated channel bindings.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Added dependency for gssapi and removed some mypy plugins.
main.py Implemented a GSSAPI example using the new aioldap3 module.
docker-compose.yml Configured container settings for the aioldap service.
aioldap3.py Added SASL GSSAPI functions, channel bindings support, and updated SASL flow.
Files not reviewed (1)
  • Dockerfile: Language not supported
Comments suppressed due to low confidence (1)

aioldap3.py:865

  • [nitpick] The function name 'proccess_end_token' is misspelled; consider renaming it to 'process_end_token' for improved clarity.
def proccess_end_token(self, token: bytes) -> bytearray:

@Naksen Naksen changed the title add: gssapi first working version add: gssapi support Apr 24, 2025
@Mastermind-U
Copy link
Collaborator Author

Мёрдж временно приостановлен из за невостребованности фичи

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants