-
Notifications
You must be signed in to change notification settings - Fork 587
[PyTorch] Documentation for op fuser API #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Greptile SummaryAdded comprehensive documentation for the operation fuser API, including a detailed usage guide with code examples, diagrams, and integration into the API reference docs. Major changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Sequential
participant FusibleOperation
participant OperationFuser
participant FusedKernel
User->>Sequential: Construct with ops
User->>Sequential: Forward pass
Sequential->>OperationFuser: Group operations
OperationFuser->>FusibleOperation: Analyze fusion opportunities
FusibleOperation-->>OperationFuser: Return fusion metadata
OperationFuser->>FusedKernel: Launch fused forward
FusedKernel-->>OperationFuser: Forward result
OperationFuser-->>Sequential: Return output
Sequential-->>User: Output tensor
User->>Sequential: Backward pass
Sequential->>OperationFuser: Trigger backward
OperationFuser->>FusedKernel: Launch fused backward
FusedKernel-->>OperationFuser: Gradients
OperationFuser-->>Sequential: Return gradients
Sequential-->>User: Loss gradients
|
Signed-off-by: Tim Moon <tmoon@nvidia.com>
Review suggestion from @greptile-apps Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
transformer_engine/pytorch/ops/basic/activation.py, line 387 (link)syntax: Extra space before period.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
19 files reviewed, 1 comment
Signed-off-by: Tim Moon <4406448+timmoon10@users.noreply.github.com>
|
/te-ci core pytorch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
.gitignore, line 44 (link)style: missing newline at end of file
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
19 files reviewed, 1 comment
Description
This PR adds a basic usage guide for the op fuser and includes it in the autogenerated API docs.
It is ready as-is, but if reviews take a while I may expand it with a guide on creating custom fused ops.
Type of change
Changes
Checklist: