Skip to content

feature/CSTACKEX-65: Aggregate selection logic for creating ONTAP Volume in StoragePool creation workflow #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandeeplocharla wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

feature/CSTACKEX-65: Aggregate selection logic for creating ONTAP Volume in StoragePool creation workflow #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...age/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/StorageStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ public boolean connect() {
throw new CloudRuntimeException("No aggregates are assigned to SVM " + svmName);
}
// Set the aggregates which are according to the storage requirements
int maxAvailableAggregateSpace = storage.getSize().intValue();
Aggregate aggrChosen = null;
for (Aggregate aggr : aggrs) {
s_logger.debug("Found aggregate: " + aggr.getName() + " with UUID: " + aggr.getUuid());
Aggregate aggrResp = aggregateFeignClient.getAggregateByUUID(authHeader, aggr.getUuid());
Expand All @@ -142,13 +144,18 @@ public boolean connect() {
s_logger.warn("Aggregate " + aggr.getName() + " does not have sufficient available space. Skipping this aggregate.");
continue;
}
s_logger.info("Selected aggregate: " + aggr.getName() + " for volume operations.");
this.aggregates = List.of(aggr);
if (aggrResp.getAvailableBlockStorageSpace() >= maxAvailableAggregateSpace) {
maxAvailableAggregateSpace = aggrResp.getAvailableBlockStorageSpace().intValue();
aggrChosen = aggr;
}
}

this.aggregates = List.of(aggrChosen);
if (this.aggregates == null || this.aggregates.isEmpty()) {
s_logger.error("No suitable aggregates found on SVM " + svmName + " for volume creation.");
throw new CloudRuntimeException("No suitable aggregates found on SVM " + svmName + " for volume creation.");
}
s_logger.info("Selected aggregate: " + aggrChosen.getName() + " for volume operations.");
s_logger.info("Successfully connected to ONTAP cluster and validated ONTAP details provided");
} catch (Exception e) {
throw new CloudRuntimeException("Failed to connect to ONTAP cluster: " + e.getMessage(), e);
Expand Down
Loading