bind on ::1 for linux and 127.0.0.1 for windows for the probe #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Have you completed the CCLA? |
Author
|
@torirevilla I will sign it on Monday. Thx :) |
Contributor
|
@Cellebyte We have not received the signed CCLA, did you get a chance to complete it? |
Author
|
@torirevilla sadly my company is still in the process. |
Author
|
@torirevilla my company signed now the CCLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
I am updating the bind-address for the probePort of the
DaemonSetfrom::to be::1for linux and127.0.0.1for windows.This secures the port from being accidentally exposed on kube-proxy Services and additional Network Interfaces which are not managed by K8s NetworkPolicy.
Project tracking
Do any added TODOs have an issue in the backlog?
Did you add unit tests? Why not?
I don't added a Unit-Test as it does not change code but only deployment behaviour.
Does this code need functional testing?
Yeah It would need to check if the basic installation still works of the DaemonSet in Windows and Linux clusters.
Is a code review walkthrough needed? why or why not?
Not really.
Should additional test coverage be executed in addition to pre-merge?
No
Does this code need a note in the changelog?
Yes, as it binds the
healthzport to localhost instead of all available IP addresses.Does this code require documentation changes?
No, as it does not add any configuration parameter.
Additional Information