Skip to content

feat: upstreaming refactored device class from erb-thesis (WIP) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ErikBjare wants to merge 1 commit into from
Closed

feat: upstreaming refactored device class from erb-thesis (WIP) #92

ErikBjare wants to merge 1 commit into from

Conversation

@ErikBjare
Copy link
Collaborator

@ErikBjare ErikBjare commented Apr 12, 2021 •
edited
Loading

Fixes #43

TODO

  • Test that things work
    • For MuseDevice
    • For BrainflowDevice
  • Check differences to eeg.py between fork and upstreaming
  • Figure out how util.py is to be used in the new structure
  • Ensure that tests and typechecking runs correctly in CI

@ErikBjare ErikBjare force-pushed the dev/updated-device-classes branch from 2941231 to f9f7a9a Compare April 12, 2021 10:47
This was referenced Apr 13, 2021
Open
Draft
@ErikBjare
Copy link
Collaborator Author

ErikBjare commented Apr 13, 2021

Closing in favor of #93

@ErikBjare ErikBjare closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Merge changes to the device abstraction ("EEG") class from my repo

1 participant

@ErikBjare