-
Notifications
You must be signed in to change notification settings - Fork 9
3825-initial-commit #3826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3825-initial-commit #3826
Conversation
Zwendle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some really small nits but otherwise looks amazing!
Co-authored-by: Zachary Wen <90429900+Zwendle@users.noreply.github.com>
cielbellerose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks so great! love how the team selection tabs on the right worked out, great idea. just a couple little comments and I second zach about making sure rule sections can be clicked and that would highlight/unhighlight all their children too
Zwendle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff🔥
Changes
Made the assign team rules tab, along with a few hooks (didn't end up using, but still useful). Made modifications to the rule row component to allow for passing in widths for the 3 sections as well as background colors for selections.
Notes
The assign team rules tab is currently using the placeholder rules, it is surprisingly difficult to use actual rulesets and rules until the ruleset and ruleset types page get fully completed. Most of the functionality was tested and works except populating previously assigned teams, and actually saving. I will be implementing those when the ruleset and ruleset types pages are complete.
Screenshots
To Do
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3825