Feature/calendar improvements #3862
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation #3754 migration to make design reviews and meetings event types
Contributor
There was a problem hiding this comment.
Pull request overview
This PR represents a comprehensive overhaul of the calendar system, transitioning from a design-review-centric model to a more flexible event-based architecture. The changes introduce new event management capabilities, availability tracking, conflict resolution, and administrative configuration tools for scheduling.
Key Changes:
- Replaced the design review calendar system with a new event-based calendar supporting multiple event types, recurring events, and resource booking (shops/machinery)
- Added comprehensive event management features including approval workflows, availability tracking, and conflict detection
- Introduced administrative configuration pages for managing calendars, event types, shops, and machinery
Reviewed changes
Copilot reviewed 96 out of 120 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| EventCard.tsx | Updated to use Event model instead of DesignReview |
| ProjectGanttChartPage.tsx | Changed references from designReviews to events |
| GanttChartColorLegend.tsx | Updated to use EventStatus instead of DesignReviewStatus |
| NewCalendarPage.tsx | New main calendar page with event filtering and conflict management |
| EventsTable.tsx | New table component for displaying user events and review bookings |
| EventModal.tsx | New comprehensive modal for creating/editing events with recurring schedules |
| CalendarTab.tsx | New tab navigation component for calendar views |
| CalendarDayCard.tsx | Updated day card to display events instead of design reviews |
| SchedulingConflictsWarning.tsx | New component for displaying scheduling conflicts |
| AdminToolsPage.tsx | Added new Schedule configuration tab |
| design-reviews.hooks.ts | Commented out design review hooks (migration to events) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -45,14 +45,14 @@ const DisplayStatus: React.FC<DesignReviewProps> = ({ designReview, user }) => { | |||
| size="small" | |||
| sx={{ color: 'white', padding: 1 }} | |||
| onClick={() => { | |||
| history.push(`${routes.SETTINGS_PREFERENCES}?drId=${designReview.designReviewId}`); | |||
| history.push(`${routes.SETTINGS_PREFERENCES}?eventId=${event.eventId}`); | |||
| }} | |||
| component={RouterLink} | |||
| > | |||
| Confirm Availibility | |||
There was a problem hiding this comment.
Corrected spelling of 'Availibility' to 'Availability'.
Suggested change
| Confirm Availibility | |
| Confirm Availability |
| sx={{ color: 'white', '&.Mui-checked': { color: 'white' } }} | ||
| /> | ||
| <Typography variant="body2" sx={{ fontSize: 14, color: 'white' }}> | ||
| Show Events I For Teams I Am On |
There was a problem hiding this comment.
The text "Show Events I For Teams I Am On" has a grammatical error. It should be "Show Events For Teams I Am On".
Suggested change
| Show Events I For Teams I Am On | |
| Show Events For Teams I Am On |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Final PR for the calendar improvements team, revamping the entire calendar page and its functionality.
Notes
Took a while but it's here now
Screenshots
Add some here soon
To Do
Bug fixes
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3400