Version 2 Beta 1 - Multiversion and -loader mayhem

.github/workflows/build_artifacts.yml

@@ -54,4 +54,4 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: Artifacts
-          path: build/libs/
+          path: ./loader/*/*/build/libs/

.github/workflows/publish.yml

@@ -26,27 +26,27 @@ jobs:
         with:
           cache-read-only: false
 
-      - name: Store short commit hash
-        run: echo "short_commit_hash=$(git rev-parse --short "$GITHUB_SHA")" >> "$GITHUB_ENV"
-
       - name: Generate resources with Gradle
         run: ./gradlew runDatagenClient
         env:
           IS_RELEASE: true
           DISABLE_PROPERTIES_UPDATE: true
+          VERSION_SUFFIX: ""
 
 
       - name: Build with Gradle
         run: ./gradlew build
         env:
           IS_RELEASE: true
           DISABLE_PROPERTIES_UPDATE: true
+          VERSION_SUFFIX: ""
 
       - name: Upload to Modrinth
         run: ./gradlew modrinth
         env:
           IS_RELEASE: true
           DISABLE_PROPERTIES_UPDATE: true
+          VERSION_SUFFIX: ""
           MODRINTH_TOKEN: ${{ secrets.MODRINTH_TOKEN }}
           VERSION_NAME: ${{ github.event.release.name }}
           VERSION_IS_PRERELEASE: ${{ github.event.release.prerelease }}
@@ -57,10 +57,11 @@ jobs:
         env:
           IS_RELEASE: true
           DISABLE_PROPERTIES_UPDATE: true
+          VERSION_SUFFIX: ""
           MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }}
           MAVEN_PASSWORD: ${{ secrets.MAVEN_PASSWORD }}
 
       - name: Upload to GitHub
         uses: softprops/action-gh-release@v2
         with:
-          files: build/libs/*.jar
+          files: ./loader/*/*/build/libs/

.gitignore

@@ -5,11 +5,36 @@ out
 classes
 
 # Fabric
-run/
-src/main/generated/*
+**/run/
+**/src/main/generated/*
 
 # Java
 hs_err_*.log
 replay_*.log
 *.hprof
 *.jfr
+
+
+
+## Docs related stuff. Docs is on separate branch, but checking out between them will leave docs stuff at the root level
+# build output
+dist/
+# generated types
+.astro/
+
+# dependencies
+node_modules/
+
+# logs
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+pnpm-debug.log*
+
+
+# environment variables
+.env
+.env.production
+
+# macOS-specific files
+.DS_Store

README.md

@@ -1,84 +1,31 @@
 # Loot Table Modifier
-[![discord-singular](https://cdn.jsdelivr.net/npm/@intergrav/devins-badges@3/assets/cozy/social/discord-singular_vector.svg)](https://discord.offsetmonkey538.top/)
-[![modrinth](https://cdn.jsdelivr.net/npm/@intergrav/devins-badges@3/assets/cozy/available/modrinth_vector.svg)](https://modrinth.com/mod/loot-table-modifier)  
+[![Chat with me on Discord](https://cdn.jsdelivr.net/npm/@intergrav/devins-badges@3/assets/cozy/social/discord-singular_vector.svg)](https://discord.offsetmonkey538.top/)
+[![Available on Modrinth](https://cdn.jsdelivr.net/npm/@intergrav/devins-badges@3/assets/cozy/available/modrinth_vector.svg)](https://modrinth.com/mod/loot-table-modifier)  
+[![Requires MonkeyLib538](https://raw.githubusercontent.com/OffsetMods538/MonkeyLib538/master/images/requires_monkeylib538.png)](https://modrinth.com/mod/monkeylib538)
 [![Requires Fabric API](https://cdn.jsdelivr.net/npm/@intergrav/devins-badges@3/assets/cozy/requires/fabric-api_vector.svg)](https://modrinth.com/mod/fabric-api)
 
-todo: good readme for alpha version
+## Why?
+Vanilla datapacks can only replace existing loot tables, which is not good for being compatible with other datapacks that also try to replace the same table.  
+This mod fixes that by implementing a system of *loot modifiers*, which do just that, modify loot (tables)!
 
-Allows datapacks to modify loot tables, instead of just overwriting them.  
-Version 2 of the mod is currently in alpha. v2 adds more ways to modify loot tables than just adding to them  
-v2 will be backwards-compatible with v1 modifiers, so no need to worry about them breaking.
+Unlike some other mods (*ahem* KubeJS) which work by running code at runtime to intercept and change drops, Loot Table Modifier modifies the loot tables as they're loaded from datapacks.  
+This means that the mod will only hurt performance during data loading, but has no performance impact during gameplay!¹
 
-If you want to use v1, then see the original description below.
-If you do decide to try out the alpha version of v2 (please do), then please go ahead and read the documentation [here](https://loot-table-modifier.docs.offsetmonkey538.top/) and if you encounter any problems, have suggestions for new actions/predicates or just want to say literally anything about the mod, please please please join my discord and tell me about it. I want to make this as good as I can and any sort of feedback really helps.  
+###### ¹ Except when you make zombies drop a bajillion stacks of diamonds or something crazy like that, but that's really not the mod's fault 😅
 
+## Usage
+### Players
+This mod does *nothing* when installed on its own. There needs to be some sort of datapack present that uses loot modifiers.  
+If you are using some mod or datapack which depends on Loot Table Modifier, just download the latest version for the Minecraft version you use from the versions page and add it to your mods folder.
 
+List of projects utilizing Loot Table Modifier:
+- I don't know of any yet 😅 Please do hit me up on discord or something if you wanna add your project here :D
 
-## Original Description
+### Mod, Modpack or Datapack developers
+Follow the documentation available [here](https://loot-table-modifier.docs.offsetmonkey538.top).
 
-Allows datapacks (and thus mods as well) to add to loot tables, instead of just overwriting them.
+This mod is allowed to be used in Modrinth modpacks.  
+I don't think I can legally prevent redistribution when using the MIT license, but I'd really appreciate if the mod wouldn't be redistributed as part of a modpack on other platforms.
 
-This mod shouldn't impact performance while playing the game, but only when datapacks are reloading (joining a world, starting a server, `/reload` command, whatever else).  
-Performance impact during pack reloading varies depending on the datapacks.  
-The mod writes how long applying modifiers took in the console.
 
-Also provides a datagen provider for creating loot table modifiers in mods.
-
-A modifier json file includes two components:
-1. `"modifies"` - string or array, which defines the loot tables to modify. For example `"minecraft:entities/creeper"` or `"minecraft:chests/abandoned_mineshaft"`
-2. `"pools"` - array of loot pools. This works exactly the same as the `"pools"` in a vanilla loot table, thus you can generate a loot table online with a tool like [misode.github.io](https://misode.github.io/loot-table/) and copy over the `"pools"` from the generated json. (I may fork it and add a generator for specifically this mod in the future™)  
-An example json file:
-```json5
-// example_pack/data/example/loot-table-modifier/loot_modifier/drop_tnt.json
-{
-    // Can also be a single identifier without an array
-    // "modifies": "minecraft:entities/creeper",
-    "modifies": [
-        "minecraft:entities/creeper",
-        "minecraft:entities/zombie"
-    ],
-    "pools": [
-        {
-            "bonus_rolls": 0.0,
-            "entries": [
-                {
-                    "type": "minecraft:item",
-                    "functions": [
-                        {
-                            "add": false,
-                            "count": {
-                                "type": "minecraft:uniform",
-                                "max": 1.0,
-                                "min": 0.0
-                            },
-                            "function": "minecraft:set_count"
-                        }
-                    ],
-                    "name": "minecraft:tnt"
-                }
-            ],
-            "rolls": 1.0
-        }
-    ]
-}
-```
-
-Depend on inside mod:
-```groovy
-repositories {
-    // ...
-    maven {
-        name = "OffsetMods538"
-        url = "https://maven.offsetmonkey538.top/releases"
-        content {
-            includeGroup "top.offsetmonkey538.loottablemodifier"
-        }
-    }
-}
-
-
-dependencies {
-    // ...
-    modImplementation "top.offsetmonkey538.loottablemodifier:loot-table-modifier:1.0.1+1.21.1"
-}
-```
+###### This mod collects anonymous usage statistics, read more about what's collected [here](https://github.com/OffsetMods538/MonkeyMetrics-Server). No personal data is collected. This can be disabled by modifying the config at `config/monkeylib538/telemetry.json` or by running the `/monkeylib538 telemetry set isEnabled false` command.