-
Notifications
You must be signed in to change notification settings - Fork 19
new Korn Shell based installer. #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: oi/hipster
Are you sure you want to change the base?
Conversation
8161281 to
94092a7
Compare
| # Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved. | ||
| # | ||
| """boot_archive_archive - Release the boot arhive mount and archive the | ||
| """boot_archive_archive - Release the boot archive mount and archive the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not related to korn shell. Please create this as a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done: #100
|
|
||
| # ============================================================================= | ||
| # ============================================================================= | ||
| # sparc_usb_confiure - Configure a populated boot archive area including usr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, has been left over from early devlopment - changed.
| # into /mnt/misc which will cause the installer's attempt to | ||
| # create a user account to fail | ||
| rm ${PKG_IMG_PATH}/etc/.pwd.lock | ||
| [ -f ${PKG_IMG_PATH}/etc/.pwd.lock ] && rm ${PKG_IMG_PATH}/etc/.pwd.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about to use rm -f ... instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is only there, because during development sometimes the file has been created, and sometimes not. If the underlying processes didn't it created it, there was always the error message: no such file or directory. I just wanted to not complain about the missing file if it hasn't been there in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and rm -f should handle that properly and silently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
| # now after the lofi filesystems are active, get rid of | ||
| # the ones in the actual root filesystem and hope it also | ||
| # works on old Ultra1 and or Ultra10 systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected - thanks
2c8f8d8 to
52267fc
Compare
d17c2c8 to
8704d50
Compare
df809e8 to
5028d38
Compare
5028d38 to
464002e
Compare
For discussion about the new installer - replacing the need for the Python text-based installer, Note nothing from the python installer has been removed in this PR, just as a proposal for discussion about future install possibility.