Fix _allowed_out_args used in UnitCompBase
#109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Contributor
Author
|
@Kenneth-T-Moore tagging you here because I can't assign a reviewer |
Kenneth-T-Moore
approved these changes
Oct 15, 2025
Member
|
Hey @A-CGray . This looks good, so I'll merge it in as soon as it passes CI. Thanks for fixing it. |
Contributor
Author
|
Thanks Ken, could we get a new patch release with this fix? |
Member
Sure, we are overdue for a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
UnitCompBaseclass inspects the input arguments ofExplicitComponent.add_outputto get the set of metadata that should be copied from its inputs to it's outputs. However, in OpenMDAO 3.40, this PR replaced most of the arguments ofExplicitComponent.add_outputwith**kwargs. This removes a bunch of entries from the copied metadata and results in several fields, includingunitsnot being copied to the outputs. I fixed this by simply inspecting the input arguments ofComponent.add_outputinstead.Full disclosure, I have absolutely no idea how pyCycle works, or what exactly this
UnitCompBasecomponent does (other than converting the units of some variables to imperial). There may well be a much better way to do this.Backwards incompatibilities
I tested this with OM 3.39 which is the last release before the change that necessitates this PR, and it is compatible.
New Dependencies
None