-
Notifications
You must be signed in to change notification settings - Fork 2
Feature | Extend Swagger Coverage for controller AppliancesApiController
#360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature | Extend Swagger Coverage for controller AppliancesApiController
#360
Conversation
4f4b976 to
9ed27c0
Compare
e351a77 to
68a9fce
Compare
e3e142a to
161d4d3
Compare
app/Http/Controllers/Apis/Marketplace/AppliancesApiController.php
Outdated
Show resolved
Hide resolved
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo please review comments
|
@smarcet please review, all the requested changes were incorporated. |
c94fc68 to
9a8387b
Compare
e468edb to
872bc36
Compare
0ea1505 to
0918db2
Compare
5d7c624 to
98fdeda
Compare
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone this PR has the same issues than @matiasperrone this PR has the same issues than #359
86778e8 to
47b070e
Compare
|
@matiasperrone please lets rebase against main and fix the conflicts many thanks |
8f5aafb to
7bd4a20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke too soon. There are build issues. Looks like a conflict with the same schema definition being defined twice:
schema: 'SummitBadgeType'
|
needs rebase. fixing now |
7bd4a20 to
4918d0e
Compare
|
@caseylocker was rebased now is working. |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Task:
Ref: https://app.clickup.com/t/86b6wkfz0