Skip to content

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo commented Sep 30, 2025

@matiasperrone-exo matiasperrone-exo self-assigned this Sep 30, 2025
@smarcet smarcet force-pushed the main branch 2 times, most recently from 4f4b976 to 9ed27c0 Compare September 30, 2025 17:46
@matiasperrone-exo matiasperrone-exo changed the title Feature | Extend Swagger Coverage for controller /Apis/Marketplace/AppliancesApiController.php Feature | Extend Swagger Coverage for controller Apis/Marketplace/AppliancesApiController.php Sep 30, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller branch from e351a77 to 68a9fce Compare September 30, 2025 19:07
@matiasperrone-exo matiasperrone-exo requested review from smarcet and removed request for smarcet September 30, 2025 19:29
@matiasperrone-exo matiasperrone-exo marked this pull request as ready for review September 30, 2025 19:51
@smarcet smarcet force-pushed the main branch 2 times, most recently from e3e142a to 161d4d3 Compare October 1, 2025 02:13
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo please review comments

@matiasperrone-exo
Copy link
Contributor Author

@smarcet please review, all the requested changes were incorporated.

@smarcet smarcet force-pushed the main branch 7 times, most recently from c94fc68 to 9a8387b Compare October 2, 2025 17:58
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller branch from e468edb to 872bc36 Compare October 6, 2025 20:05
@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 7, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller branch from 0ea1505 to 0918db2 Compare October 7, 2025 21:02
@matiasperrone-exo matiasperrone-exo changed the title Feature | Extend Swagger Coverage for controller Apis/Marketplace/AppliancesApiController.php Feature | Extend Swagger Coverage for controller AppliancesApiController.php Oct 7, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller branch 2 times, most recently from 5d7c624 to 98fdeda Compare October 7, 2025 21:30
Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone this PR has the same issues than @matiasperrone this PR has the same issues than #359

@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 18, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller branch from 86778e8 to 47b070e Compare November 27, 2025 15:54
@smarcet
Copy link
Collaborator

smarcet commented Dec 4, 2025

@matiasperrone please lets rebase against main and fix the conflicts many thanks

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller branch 2 times, most recently from 8f5aafb to 7bd4a20 Compare December 9, 2025 19:51
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke too soon. There are build issues. Looks like a conflict with the same schema definition being defined twice:
schema: 'SummitBadgeType'

@matiasperrone-exo
Copy link
Contributor Author

needs rebase. fixing now

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---marketplace--appliancesapicontroller branch from 7bd4a20 to 4918d0e Compare December 11, 2025 18:56
@matiasperrone-exo
Copy link
Contributor Author

@caseylocker was rebased now is working.

Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 544669d into main Dec 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants