Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 11, 2024

No description provided.

dweindl and others added 10 commits July 3, 2024 16:31
For now just imports from v1
- Use `copy` of conditions DataFrame for inplace sorting
- closes PEtab-dev#304 

---------

Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
…Etab-dev#309)

Reformulate the given PEtab problem such that the objective priors are converted to measurements. This is done by adding a new observable for each prior and adding a corresponding measurement to the measurement table. The resulting optimization problem will be equivalent to the original problem. This is meant to be used for tools that do not support priors.

Closes PEtab-dev#307
---------

Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
petab.v1.priors was not included in the documentation.
Appending instead of preprending the new observables/measurements will preserve the column order.
If no ID is given, use `pysb.Model.name` as fallback. As is already the case for SbmlModel and its `id` attribute.
Include the model ID in `Model.__repr__`.
* Remove the visualization table if it has observables that are not in the flattened observable table.

Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@dweindl dweindl requested a review from a team as a code owner November 11, 2024 09:51
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 64.47368% with 27 lines in your changes missing coverage. Please review.

Project coverage is 72.79%. Comparing base (b0e0e54) to head (3e36584).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
petab/v1/priors.py 70.90% 7 Missing and 9 partials ⚠️
petab/v1/core.py 0.00% 4 Missing and 1 partial ⚠️
petab/v1/models/pysb_model.py 66.66% 1 Missing and 1 partial ⚠️
petab/v2/models/__init__.py 0.00% 1 Missing ⚠️
petab/v2/models/model.py 0.00% 1 Missing ⚠️
petab/v2/models/pysb_model.py 0.00% 1 Missing ⚠️
petab/v2/models/sbml_model.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   72.87%   72.79%   -0.08%     
==========================================
  Files          47       52       +5     
  Lines        4836     4907      +71     
  Branches     1035      841     -194     
==========================================
+ Hits         3524     3572      +48     
- Misses       1014     1028      +14     
- Partials      298      307       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dweindl dweindl merged commit 99373c4 into PEtab-dev:main Nov 11, 2024
6 checks passed
@dweindl dweindl deleted the release_0.5.0 branch November 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants