Skip to content

Problem.add_parameter: Rename kwarg estimated->estimate #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dweindl merged 3 commits into from
Dec 19, 2024
Merged

Problem.add_parameter: Rename kwarg estimated->estimate #348

dweindl merged 3 commits into from
Dec 19, 2024

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 18, 2024

Change the estimated argument in Problem.add_parameter to estimate to match the column name.

@dweindl dweindl requested a review from a team as a code owner December 18, 2024 22:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.61%. Comparing base (e7edebf) to head (2926214).
Report is 36 commits behind head on develop.

Files with missing lines Patch % Lines
petab/v1/problem.py 50.00% 0 Missing and 1 partial ⚠️
petab/v2/problem.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #348   +/-   ##
========================================
  Coverage    74.61%   74.61%           
========================================
  Files           56       56           
  Lines         5571     5571           
  Branches       978      978           
========================================
  Hits          4157     4157           
  Misses        1041     1041           
  Partials       373      373

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
Problem.add_parameter: Rename kwarg estimated->estimate
8a40932 
Change the `estimated` argument in Problem.add_parameter to `estimate`
to match the column name.
@dweindl dweindl force-pushed the add_parameter_estimate branch from 70d3bfe to 8a40932 Compare December 18, 2024 22:23
dilpath
dilpath approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dweindl and others added 2 commits December 19, 2024 08:46
@dweindl @dilpath
Apply suggestions from code review
54624fe 
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@dweindl
..
2926214
@dweindl dweindl self-assigned this Dec 19, 2024
@dweindl dweindl merged commit 9f11e73 into PEtab-dev:develop Dec 19, 2024
7 checks passed
@dweindl dweindl deleted the add_parameter_estimate branch December 19, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dilpath dilpath dilpath approved these changes

Assignees

@dweindl dweindl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dweindl @codecov-commenter @dilpath