Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Dec 20, 2024

  • don't create unnecessary experiment tables
  • write yaml file after updating the config dict
  • check for missing experiments
  • handle anonymous experiments

@dweindl dweindl requested a review from a team as a code owner December 20, 2024 11:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.89%. Comparing base (6e762c6) to head (6053934).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
petab/v2/lint.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #351      +/-   ##
===========================================
+ Coverage    74.84%   74.89%   +0.04%     
===========================================
  Files           56       56              
  Lines         5597     5604       +7     
  Branches       980      982       +2     
===========================================
+ Hits          4189     4197       +8     
  Misses        1033     1033              
+ Partials       375      374       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl force-pushed the v2_validation_fixes branch 2 times, most recently from d3dd841 to 04670c9 Compare December 20, 2024 12:59
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl force-pushed the v2_validation_fixes branch from ad9ba38 to 6053934 Compare December 20, 2024 14:04
@dweindl dweindl merged commit ec58463 into PEtab-dev:develop Dec 20, 2024
7 checks passed
@dweindl dweindl deleted the v2_validation_fixes branch December 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants