Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Mar 10, 2025

No description provided.

@dweindl dweindl marked this pull request as ready for review March 10, 2025 13:39
@dweindl dweindl mentioned this pull request Mar 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50%. Comparing base (dbd7e04) to head (7bb49a7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #354   +/-   ##
========================================
  Coverage    74.50%   74.50%           
========================================
  Files           57       57           
  Lines         6002     6002           
  Branches      1039     1039           
========================================
  Hits          4472     4472           
  Misses        1133     1133           
  Partials       397      397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl requested a review from a team March 11, 2025 13:27
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


2. Update the changelog in ``doc/CHANGELOG.md``.

3. Create a pull request with the changes to the main branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this from develop? Or some release_v101 like

git checkout develop
git pull
git checkout -b release_v101
git add petab/version.py doc/CHANGELOG.md
git commit -m 'bump version; update changelog'

If the latter then some more info is needed I think. "simple merge" to main, then merge main into develop.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave that to the releasing person and assume some basic familiarity with git/github.

dweindl and others added 6 commits March 13, 2025 09:47
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
@dweindl dweindl merged commit ff77842 into PEtab-dev:develop Mar 13, 2025
7 checks passed
@dweindl dweindl deleted the update_dev_guide branch March 13, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants