Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Mar 12, 2025

  • Simplify linking to the PEtab specs
  • Add tox env for building the documentation

@dweindl dweindl marked this pull request as ready for review March 12, 2025 11:44
@dweindl dweindl requested a review from a team as a code owner March 12, 2025 11:44
@dweindl
Copy link
Member Author

dweindl commented Mar 12, 2025

RTD builds pass. Remaining test failures are fixed in #345

- measurement table
- parameter table
- observables table
- mapping table
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mapping in v1? Fine for this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mapping in v1 in principle, but it was added there long ago for initial v2 support before we decided to have a separate v2.Problem. We should keep it there until petab.v2 has converged.

* Simplify linking to the PEtab specs
* Add tox env for building the documentation
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50%. Comparing base (ff77842) to head (357e3fc).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #358   +/-   ##
========================================
  Coverage    74.50%   74.50%           
========================================
  Files           57       57           
  Lines         6002     6002           
  Branches      1039     1039           
========================================
  Hits          4472     4472           
  Misses        1133     1133           
  Partials       397      397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl enabled auto-merge (squash) March 13, 2025 09:03
@dweindl dweindl merged commit 84f7875 into PEtab-dev:develop Mar 13, 2025
7 checks passed
@dweindl dweindl deleted the intersphinx branch December 3, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants