doc: petab.v2.core #360
doc: petab.v2.core #360
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #360 +/- ##
========================================
Coverage 74.44% 74.44%
========================================
Files 57 57
Lines 5987 5987
Branches 1039 1039
========================================
Hits 4457 4457
Misses 1133 1133
Partials 397 397 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Looks good 👍
The "module attributes" (ObjectivePriorType, InitializationPriorType) are listed on RTD but not doc'd -- is this because they might be refactored? Fine for me.
| >>> Change( | ||
| ... target_id="k1", | ||
| ... operation_type=OperationType.SET_CURRENT_VALUE, | ||
| ... target_value="10", |
There was a problem hiding this comment.
Using "10" is fine but it looks like int/float is handled? Is this to stress that the type is an expression? Then maybe using e.g. k1+3 makes the point better.
There was a problem hiding this comment.
That's to test that strings are accepted/converted.
That's because they are just aliases. Either we have separate types, or we only have the members of the original type documented. And yes, I wouldn't bother until it's decided whether/how they will change. |
3 participants
👀 https://petab--360.org.readthedocs.build/projects/libpetab-python/en/360/build/_autosummary/petab.v2.core.html