Skip to content

v2: Parameter.estimate -> bool #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dweindl merged 2 commits into from
Mar 28, 2025
Merged

v2: Parameter.estimate -> bool #368

dweindl merged 2 commits into from
Mar 28, 2025

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Mar 27, 2025

  • Update serialization
  • Update upconversion
  • Update tests

@dweindl
v2: Parameter.estimate -> bool
539d8a7 
* Update serialization
* Update upconversion
* Update tests
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (7ab7cd8) to head (504c9a8).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #368      +/-   ##
===========================================
+ Coverage    74.57%   74.58%   +0.01%     
===========================================
  Files           58       58              
  Lines         6119     6122       +3     
  Branches      1062     1061       -1     
===========================================
+ Hits          4563     4566       +3     
  Misses        1149     1149              
  Partials       407      407

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review March 27, 2025 20:14
@dweindl dweindl requested a review from a team as a code owner March 27, 2025 20:14
dilpath
dilpath approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 8614c02 into PEtab-dev:develop Mar 28, 2025
7 checks passed
@dweindl dweindl deleted the v2_estimate_bool branch March 28, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dilpath dilpath dilpath approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dweindl @codecov-commenter @dilpath