v2: Adapt models to changes in prior distributions #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #378 +/- ##
===========================================
+ Coverage 74.17% 74.27% +0.10%
===========================================
Files 58 58
Lines 6234 6239 +5
Branches 1084 1082 -2
===========================================
+ Hits 4624 4634 +10
+ Misses 1204 1199 -5
Partials 406 406 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* priorDistribution/priorParameters instead of separate initializationPrior&objectivePrior * additional prior distributions Related to PEtab-dev#374.
dilpath
approved these changes
Apr 24, 2025
| #: Log-normal distribution | ||
| LOG_NORMAL = "log-normal" | ||
| #: Log-uniform distribution. | ||
| LOG_UNIFORM = "log-uniform" |
Member
There was a problem hiding this comment.
Not really in-scope for this PR but is log10-uniform missing? I guess this is how we would convert parameterScale=log10 into PEtab v2, or is that just no longer possible?
Member
Author
There was a problem hiding this comment.
It's not included in PEtab-dev/PEtab#595. So, so far, it's not available in PEtab v2. Right, I guess we'd need it to upconvert v1 priors. Also log10-laplace. Best to be discussed at https://github.com/PEtab-dev/PEtab.
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #374.