Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 22, 2025

For petab.v2 pydantic models, change path attributes to pathlib.Path, and validate assignments.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.88%. Comparing base (f9bad6a) to head (b6f7136).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   73.86%   73.88%   +0.02%     
==========================================
  Files          62       62              
  Lines        6764     6771       +7     
  Branches     1194     1196       +2     
==========================================
+ Hits         4996     5003       +7     
  Misses       1308     1308              
  Partials      460      460              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

For petab.v2 pydantic models, change path attributes to `pathlib.Path`, and
validate assignments.
@dweindl dweindl force-pushed the v2_validate_assign branch from d5fa2ec to b6f7136 Compare July 22, 2025 07:18
@dweindl dweindl marked this pull request as ready for review July 22, 2025 07:34
@dweindl dweindl requested a review from a team as a code owner July 22, 2025 07:34
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For multiple e.g. measurement tables, are the (relative) paths stored with the table names? If so, is there a method for users to add a table via a path, to a pre-existing list of measurement tables? If not, how should multiple tables be written to disk? Manually specify each individual table filename each write?

@dweindl
Copy link
Member Author

dweindl commented Jul 22, 2025

For multiple e.g. measurement tables, are the (relative) paths stored with the table names?

Not yet.

If not, how should multiple tables be written to disk? Manually specify each individual table filename each write?

To be decided.

@dweindl
Copy link
Member Author

dweindl commented Jul 22, 2025

We should probably drop ProblemConfig from petab.Problem and keep only the relevant info there, and then store relative paths in the *Table objects. Anything else will be rather inconvenient. With having those filepaths in both the *Table objects and ProblemConfig things will get out of sync.

@dilpath
Copy link
Member

dilpath commented Jul 22, 2025

Yes, moving the information to the table objects sounds nice to me 👍 Default filenames so that we can still have some kind of problem.to_files_generic would also be nice.

@dweindl dweindl merged commit 11db39d into PEtab-dev:main Jul 22, 2025
7 checks passed
@dweindl dweindl deleted the v2_validate_assign branch July 22, 2025 09:01
@dweindl dweindl self-assigned this Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants