v1v2-converter: handle log10-normal #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 73.83% 73.84% +0.01%
==========================================
Files 61 61
Lines 6756 6760 +4
Branches 1196 1197 +1
==========================================
+ Hits 4988 4992 +4
Misses 1308 1308
Partials 460 460 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PEtab v2 does not support log10-type distributions. When upconverting PEtab v1 problems, replace log10-normal by log-normal and emit a warning.
dweindl
force-pushed
the
v1v2_log10normal
branch
from
27550ac to
cb32d94
Compare
dilpath
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEtab v2 does not support log10-type noise distributions. When upconverting PEtab v1 problems, replace log10-normal by log-normal and emit a warning.