Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 22, 2025

Move v2.problem.* to v2.core. Keep all pydantic models in the same module. Avoid unnecessary import complexity.

Move `v2.problem.*` to `v2.core`. Keep all pydantic models in the same module. Avoid unnecessary import complexity.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.30151% with 158 lines in your changes missing coverage. Please review.

Project coverage is 73.83%. Comparing base (11db39d) to head (726b247).

Files with missing lines Patch % Lines
petab/v2/core.py 60.20% 122 Missing and 36 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   73.88%   73.83%   -0.06%     
==========================================
  Files          62       61       -1     
  Lines        6771     6756      -15     
  Branches     1196     1196              
==========================================
- Hits         5003     4988      -15     
  Misses       1308     1308              
  Partials      460      460              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl self-assigned this Jul 22, 2025
@dweindl dweindl marked this pull request as ready for review July 22, 2025 11:35
@dweindl dweindl requested a review from a team as a code owner July 22, 2025 11:35
@dweindl dweindl merged commit af3e707 into PEtab-dev:main Jul 23, 2025
7 checks passed
@dweindl dweindl deleted the v2_merge_problem_core branch July 23, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants