Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 24, 2025

Related to #392.

  • Let v2.Problem have a list of models
  • Support constructing v2.Problem from files with multiple models
  • Move some validators to Annotated
  • Add some TODOs.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.39%. Comparing base (5e26769) to head (250d87c).

Files with missing lines Patch % Lines
petab/v2/core.py 76.92% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   74.40%   74.39%   -0.01%     
==========================================
  Files          61       61              
  Lines        6692     6691       -1     
  Branches     1182     1181       -1     
==========================================
- Hits         4979     4978       -1     
- Misses       1256     1257       +1     
+ Partials      457      456       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl self-assigned this Jul 24, 2025
@dweindl dweindl marked this pull request as ready for review July 24, 2025 14:32
@dweindl dweindl requested a review from a team as a code owner July 24, 2025 14:32
Copy link
Collaborator

@m-philipps m-philipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, nothing important to add from my side.

)

@model.setter
def model(self, value: Model):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change the name to make it clear that this modifies the Problem, e.g. set_model?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model is a property. This function here is usually invoked via problem.model = some_model, it cannot be invoked as problem.model(some_model). I think the assignment should make it clear that this modifies the object.

Related to PEtab-dev#392.

* Let v2.Problem have a list of models
* Support constructing v2.Problem from files with multiple models
* Move some validators to Annotated
* Add some TODOs.
@dweindl dweindl force-pushed the multi_model_basics branch from 96e40eb to 250d87c Compare July 29, 2025 05:23
@dweindl dweindl merged commit 3156df2 into PEtab-dev:main Jul 29, 2025
7 checks passed
@dweindl dweindl deleted the multi_model_basics branch July 29, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants