Skip to content

Remove parameter mapping from v2.Problem #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 1 commit into from
Jul 29, 2025
Merged

Remove parameter mapping from v2.Problem #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions petab/v2/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
from typing_extensions import Self

from ..v1 import (
parameter_mapping,
validate_yaml_syntax,
yaml,
)
Expand Down Expand Up @@ -1775,24 +1774,6 @@ def x_fixed_indices(self) -> list[int]:
"""Parameter table non-estimated parameter indices."""
return [i for i, p in enumerate(self.parameters) if not p.estimate]

# TODO remove in v2?
def get_optimization_to_simulation_parameter_mapping(self, **kwargs):
"""
See
:py:func:`petab.parameter_mapping.get_optimization_to_simulation_parameter_mapping`,
to which all keyword arguments are forwarded.
"""
return (
parameter_mapping.get_optimization_to_simulation_parameter_mapping(
condition_df=self.condition_df,
measurement_df=self.measurement_df,
parameter_df=self.parameter_df,
observable_df=self.observable_df,
model=self.model,
**kwargs,
)
)

def get_priors(self) -> dict[str, Distribution]:
"""Get prior distributions.

Expand Down
Loading