Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Aug 21, 2025

Check that we have a valid model ID. Related to #392.

@dweindl dweindl self-assigned this Aug 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.67%. Comparing base (a78fa0a) to head (24e4c48).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   74.59%   74.67%   +0.07%     
==========================================
  Files          62       62              
  Lines        6736     6751      +15     
  Branches     1188     1193       +5     
==========================================
+ Hits         5025     5041      +16     
  Misses       1256     1256              
+ Partials      455      454       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review August 21, 2025 10:44
@dweindl dweindl requested a review from a team as a code owner August 21, 2025 10:44
Check that we have a valid model ID. Related to PEtab-dev#392.
Copy link
Collaborator

@m-philipps m-philipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dweindl dweindl merged commit 8795dbf into PEtab-dev:main Aug 26, 2025
7 checks passed
@dweindl dweindl deleted the validate_modelid branch August 26, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants