Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Aug 21, 2025

After PEtab-dev/PEtab#645, any condition that is used as a first condition cannot refer to any symbols other then the parameters listed in the parameter table, or `time'.

Closes #424.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.82%. Comparing base (de974ba) to head (4df1ecb).

Files with missing lines Patch % Lines
petab/v2/lint.py 76.92% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   74.81%   74.82%   +0.01%     
==========================================
  Files          62       62              
  Lines        6765     6792      +27     
  Branches     1195     1203       +8     
==========================================
+ Hits         5061     5082      +21     
- Misses       1252     1255       +3     
- Partials      452      455       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review August 26, 2025 08:46
@dweindl dweindl requested a review from a team as a code owner August 26, 2025 08:46
@dweindl dweindl self-assigned this Aug 26, 2025
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

applied at the start of an experiment."""
problem = Problem()
problem.model = SbmlModel.from_antimony("p1 = 1; p2 = 2")
problem.add_experiment("e1", 0, "c1", 1, "c2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated: the docstring for add_experiment is currently missing that multiple conditions applied at a single timepoint are specified as a list inside args

def add_experiment(self, id_: str, *args):
"""Add an experiment to the problem.
If there are more than one experiment tables, the experiment
is added to the last one.
:param id_: The experiment ID.
:param args: Timepoints and associated conditions:
``time_1, condition_id_1, time_2, condition_id_2, ...``.
"""

@dweindl dweindl force-pushed the validate_initial_changes branch from 72afccb to f8f18e0 Compare September 19, 2025 20:14
After PEtab-dev/PEtab#645, any condition that is used as a first condition cannot refer to any symbols other then the parameters listed in the parameter table, or `time'.

Closes PEtab-dev#424.
@dweindl dweindl force-pushed the validate_initial_changes branch from f8f18e0 to 4df1ecb Compare September 19, 2025 20:34
@dweindl dweindl merged commit 900f8b6 into PEtab-dev:main Sep 19, 2025
7 checks passed
@dweindl dweindl deleted the validate_initial_changes branch September 19, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update v2 condition table targetValue validation

3 participants